Conversation
JuliDi
approved these changes
May 6, 2026
Member
JuliDi
left a comment
JuliDi
left a comment
There was a problem hiding this comment.
Looks good overall, just two suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generate a salt if none is provided (fixes Issue #2), if a salt is entered it is being checked before prompting for a password (fixes Issue #1). Also, this let's the user actually choose between argon2 version 10 and version 13 hashes, this was unimplemented before.
I bumped the minor version because this means the program will generate a different output for the same input now, albeit only in failure cases, the happy flow should stay identical.